Replaced uses of SecurityRoles by Set<String> mappedRoles where the SecurityRoles functionality is not needed #4432
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This code change is just in preparation for the change in #4380 as requested in #4380 (comment) .
In the course of #4380 , the
SecurityRoles
class will be replaced by a new concept. This PR already replaces the usages ofSecurityRoles
where no methods are used on it except thegetRoleNames()
method. This method call can be easily replaced by theSet<String> mappedRoles
, which is computed byPrivilegesEvaluator
before theSecurityRoles
instance is created. This change elliminated the coupling of the interfaces that consume that information to theSecurityRoles
class, thereby enhancing code quality.SecurityRoles
class in the end.Issues Resolved
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.