Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump OpenSAML to version 5.0.0 #3603

Closed

Conversation

willyborankin
Copy link
Collaborator

Description

Just a small test

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Andrey Pleskach <[email protected]>
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #3603 (c80e164) into main (60c9a86) will decrease coverage by 0.19%.
The diff coverage is 62.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3603      +/-   ##
============================================
- Coverage     64.90%   64.71%   -0.19%     
+ Complexity     3639     3634       -5     
============================================
  Files           284      284              
  Lines         20619    20617       -2     
  Branches       3391     3391              
============================================
- Hits          13382    13342      -40     
- Misses         5556     5598      +42     
+ Partials       1681     1677       -4     
Files Coverage Δ
...zon/dlic/auth/http/saml/HTTPSamlAuthenticator.java 67.36% <100.00%> (ø)
...zon/dlic/auth/http/saml/Saml2SettingsProvider.java 60.18% <ø> (ø)
...auth/http/saml/SamlFilesystemMetadataResolver.java 0.00% <ø> (ø)
...azon/dlic/util/SettingsBasedSSLConfiguratorV4.java 59.09% <0.00%> (-0.30%) ⬇️
.../dlic/auth/http/saml/SamlHTTPMetadataResolver.java 57.69% <50.00%> (-5.28%) ⬇️

... and 3 files with indirect coverage changes

@willyborankin
Copy link
Collaborator Author

OpenSAML 5.x uses minimum JDK 17. Not sure that we can continue with it

@peternied
Copy link
Member

@willyborankin could you open up an issue about this for the security repo to capture?

Maybe good news 🤷 it there is already discussion [1] in favor of dropping support for jdk11 in 3.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants