[Backport 2.x] Added secure settings for ssl related passwords: (#2296) #3037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2296) Added secure settings for ssl related passwords: * plugins.security.ssl.http.pemkey_password_secure * plugins.security.ssl.http.keystore_password_secure * plugins.security.ssl.http.keystore_keypassword_secure * plugins.security.ssl.http.truststore_password_secure * plugins.security.ssl.transport.pemkey_password_secure * plugins.security.ssl.transport.server.pemkey_password_secure * plugins.security.ssl.transport.client.pemkey_password_secure * plugins.security.ssl.transport.keystore_password_secure * plugins.security.ssl.transport.keystore_keypassword_secure * plugins.security.ssl.transport.server.keystore_keypassword_secure * plugins.security.ssl.transport.client.keystore_keypassword_secure * plugins.security.ssl.transport.truststore_password_secure Signed-off-by: Chris White <[email protected]> (cherry picked from commit 2c20be0)
DarshitChanpura
requested review from
cliu123,
cwperks,
davidlago,
peternied,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
DarshitChanpura
changed the title
|
Unblocked now. |
Signed-off-by: Darshit Chanpura <[email protected]>
|
Temporarily changing the base helped resolve the issue of the latest commits from the backport branch not being reflected here. Edit: Needed to force-push same commit because DCO erroneously broke due to temporary change in base |
Signed-off-by: Darshit Chanpura <[email protected]>
DarshitChanpura
force-pushed
the
backport/backport-2296-to-2.x
branch
from
6a5401b to
47cd84d
Compare
RyanL1997
previously approved these changes
Jul 21, 2023
Codecov Report
@@ Coverage Diff @@
## 2.x #3037 +/- ##
============================================
- Coverage 62.25% 62.21% -0.04%
+ Complexity 3315 3314 -1
============================================
Files 264 265 +1
Lines 19471 19488 +17
Branches 3326 3328 +2
============================================
+ Hits 12121 12124 +3
- Misses 5722 5734 +12
- Partials 1628 1630 +2
|
willyborankin
previously approved these changes
Jul 21, 2023
Signed-off-by: Darshit Chanpura <[email protected]>
DarshitChanpura
dismissed stale reviews from RyanL1997 and willyborankin
via
1be111b
DarshitChanpura
force-pushed
the
backport/backport-2296-to-2.x
branch
from
f6f26e1 to
1be111b
Compare
Signed-off-by: Darshit Chanpura <[email protected]>
RyanL1997
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backports 2c20be0 from #2296
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.