-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Rest admin permissions (#2411) #2806
[Backport 2.x] Rest admin permissions (#2411) #2806
Conversation
Permissions for REST admin user Added granular permissions for all REST API actions in OpenSearch to be individually assigned. Permissions are: - 'restapi:admin/actiongroups' - allow full access to actiongroups - 'restapi:admin/allowlist' - allow full access to allowlist - 'restapi:admin/internalusers'- allow full access to internalusers - 'restapi:admin/nodesdn'- allow full access to nodesdn - 'restapi:admin/roles' - allow full access to roles - 'restapi:admin/rolesmapping' - allow full access to roles mappings - 'restapi:admin/ssl/certs/info' - allow full access to certs info - 'restapi:admin/ssl/certs/reload' - allow full access to certs reload - 'restapi:admin/tenants' - allow full access to tenants Adds tests for these permissions. Signed-off-by: Andrey Pleskach <[email protected]> (cherry picked from commit d676716)
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
@willyborankin Would you please review the changes? |
@DarshitChanpura wdyt about opening up the same PR against 2.8 to expedite the backport process to that branch? |
Done. 😃 #2807 |
Signed-off-by: Darshit Chanpura <[email protected]>
Codecov Report
@@ Coverage Diff @@
## 2.x #2806 +/- ##
============================================
+ Coverage 61.26% 61.37% +0.10%
- Complexity 3316 3368 +52
============================================
Files 264 264
Lines 18507 18631 +124
Branches 3265 3283 +18
============================================
+ Hits 11338 11434 +96
- Misses 5593 5611 +18
- Partials 1576 1586 +10
|
Remove unused import
Signed-off-by: Darshit Chanpura <[email protected]>
@@ -289,7 +289,6 @@ configurations.all { | |||
} | |||
|
|||
dependencies { | |||
implementation 'jakarta.annotation:jakarta.annotation-api:1.3.5' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change should already be part of 2.x via https://github.com/opensearch-project/security/pull/2803/files
but isn't
Permissions for REST admin user
Added granular permissions for all REST API actions in OpenSearch to be individually assigned.
Permissions are:
- 'restapi:admin/actiongroups' - allow full access to actiongroups
- 'restapi:admin/allowlist' - allow full access to allowlist
- 'restapi:admin/internalusers'- allow full access to internalusers
- 'restapi:admin/nodesdn'- allow full access to nodesdn
- 'restapi:admin/roles' - allow full access to roles
- 'restapi:admin/rolesmapping' - allow full access to roles mappings
- 'restapi:admin/ssl/certs/info' - allow full access to certs info
- 'restapi:admin/ssl/certs/reload' - allow full access to certs reload
- 'restapi:admin/tenants' - allow full access to tenants
Adds tests for these permissions.
Signed-off-by: Andrey Pleskach [email protected]
(cherry picked from commit d676716)
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Is this a backport? If so, please add backport PR # and/or commits #
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.