Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.4] Fix issues with datastream backing indexes #2242

Merged
merged 3 commits into from
Nov 8, 2022

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Nov 7, 2022

Backport of f7cc569 to 2.4

* Resolving backing indices of data streams when resolving for aliases

* Fixing resolution of indices for non-wild card scenarios / exact matches

* Adding tests for DLS/FLS/Field-Masking on Data Streams

Co-authored-by: Sandesh Kumar <[email protected]>
@cwperks cwperks requested a review from a team November 7, 2022 22:10
davidlago
davidlago previously approved these changes Nov 7, 2022
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2022

Codecov Report

Merging #2242 (8785b25) into 2.4 (982f281) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                2.4    #2242      +/-   ##
============================================
- Coverage     61.08%   61.00%   -0.08%     
+ Complexity     3251     3244       -7     
============================================
  Files           258      258              
  Lines         18123    18125       +2     
  Branches       3231     3231              
============================================
- Hits          11070    11058      -12     
- Misses         5481     5493      +12     
- Partials       1572     1574       +2     
Impacted Files Coverage Δ
...pensearch/security/securityconf/ConfigModelV7.java 63.42% <100.00%> (+0.12%) ⬆️
...ecurity/configuration/StaticResourceException.java 0.00% <0.00%> (-25.00%) ⬇️
...nsearch/security/dlic/rest/api/AuditApiAction.java 63.82% <0.00%> (-4.26%) ⬇️
...ecurity/configuration/ConfigurationRepository.java 72.13% <0.00%> (-2.19%) ⬇️
.../dlic/auth/ldap2/LDAPConnectionFactoryFactory.java 57.46% <0.00%> (-1.50%) ⬇️
...iance/ComplianceIndexingOperationListenerImpl.java 61.76% <0.00%> (-1.48%) ⬇️
...ensearch/security/compliance/ComplianceConfig.java 81.94% <0.00%> (-1.39%) ⬇️
...a/org/opensearch/security/tools/SecurityAdmin.java 35.63% <0.00%> (-0.13%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@peternied
Copy link
Member

Still waiting on the fix to be backported and build in the 2.4 snapshot

@dblock
Copy link
Member

dblock commented Nov 8, 2022

Rebase please, opensearch-project/OpenSearch#5132 includes the nebula fix.

@cwperks
Copy link
Member Author

cwperks commented Nov 8, 2022

This is already based on the head of the 2.4 branch. We will need to wait for new opensearch core artifacts before re-running the CI.

@peternied peternied merged commit bca4612 into opensearch-project:2.4 Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants