[Backport 2.x] Conform to Navigation changes from OSD core #2045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Adopt to nav changes in core Signed-off-by: Derek Ho <[email protected]> * Lint Signed-off-by: Derek Ho <[email protected]> * feat: enable data source info in new left navigation Signed-off-by: SuZhou-Joe <[email protected]> * feat: enable data source info in new left navigation Signed-off-by: SuZhou-Joe <[email protected]> * Address PR feedback Signed-off-by: Derek Ho <[email protected]> * Lint Signed-off-by: Derek Ho <[email protected]> * Fix lint and tests Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: SuZhou-Joe <[email protected]> (cherry picked from commit 2f8c6f4)
opensearch-trigger-bot
bot
requested review from
cliu123,
cwperks,
DarshitChanpura,
derek-ho,
RyanL1997 and
stephen-crawford
as code owners
derek-ho
approved these changes
Jul 19, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #2045 +/- ##
==========================================
- Coverage 70.36% 69.34% -1.02%
==========================================
Files 96 96
Lines 2541 2587 +46
Branches 377 382 +5
==========================================
+ Hits 1788 1794 +6
- Misses 660 699 +39
- Partials 93 94 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 2f8c6f4 from #2022