Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove service accounts from Main #2041

Merged
merged 8 commits into from
Jul 18, 2024
Merged

Conversation

derek-ho
Copy link
Collaborator

@derek-ho derek-ho commented Jul 17, 2024

Description

Service account pages/code was introduced in main but never backported to 2.x. This code difference caused backports involving internalusers code to fail, leading to manual backports and conflict resolution errors. This removes that code since there is no current path forward for service accounts, so backports won't fail anymore. If and when there is a plan to bring service accounts to main and 2.x, we can re-introduce that code.

Category

Maintenance

Why these changes are required?

Fix #2005

What is the old behavior before changes and new behavior after changes?

Service accounts code doesn't exist in main anymore

Issues Resolved

Fix #2005

Testing

Existing tests pass, manual testing

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
@derek-ho derek-ho marked this pull request as ready for review July 17, 2024 16:08
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.36%. Comparing base (0592b68) to head (c214213).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2041      +/-   ##
==========================================
- Coverage   70.61%   70.36%   -0.25%     
==========================================
  Files          97       96       -1     
  Lines        2600     2541      -59     
  Branches      387      370      -17     
==========================================
- Hits         1836     1788      -48     
+ Misses        668      660       -8     
+ Partials       96       93       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

DEVELOPER_GUIDE.md Outdated Show resolved Hide resolved
cwperks
cwperks previously approved these changes Jul 17, 2024
@derek-ho derek-ho dismissed stale reviews from cwperks and DarshitChanpura via 341703c July 17, 2024 19:14
@derek-ho
Copy link
Collaborator Author

@cwperks @DarshitChanpura can you also review this PR in the FTR related to this change opensearch-project/opensearch-dashboards-functional-test#1444? Running those tests as part of this repo is showing useful as we can catch changes that will affect these tests as part of the PR process.

@derek-ho derek-ho merged commit c523578 into opensearch-project:main Jul 18, 2024
16 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Remove service account code in main
3 participants