Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.11] Disable tenancy pop-ups when disabled or default tenant set #1765

Closed
wants to merge 1 commit into from

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport b1e986c from #1759

Signed-off-by: Derek Ho <[email protected]>
Co-authored-by: Darshit Chanpura <[email protected]>
(cherry picked from commit b1e986c)
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2af71cf) 66.18% compared to head (3e47081) 66.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##             2.11    #1765      +/-   ##
==========================================
+ Coverage   66.18%   66.36%   +0.18%     
==========================================
  Files          93       93              
  Lines        2339     2343       +4     
  Branches      312      314       +2     
==========================================
+ Hits         1548     1555       +7     
+ Misses        722      720       -2     
+ Partials       69       68       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@stephen-crawford stephen-crawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason this is being backported to an already released branch?

@DarshitChanpura
Copy link
Member

No plan to merge.

@cwperks cwperks reopened this Feb 5, 2024
@peternied peternied self-requested a review February 5, 2024 18:38
Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't backport this unless to any branch other than 2.x without a reason - waiting till we've got that documented.

@davidlago
Copy link

No plans to release further 2.11.x versions

@davidlago davidlago closed this Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants