Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Pass in env variable and -t flag to set "admin" as the initial admin password #1708

Merged
merged 3 commits into from
Dec 26, 2023

Conversation

derek-ho
Copy link
Collaborator

Description

Consumes changes in 2.x line of security backend plugin that requires admin password to be set via an environment variable. Also changes the CI to run in "test" mode to accept the weak admin password "admin".

Category

[Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation]

Why these changes are required?

What is the old behavior before changes and new behavior after changes?

Issues Resolved

[List any issues this PR will resolve (Is this a backport? If so, please add backport PR # and/or commits #)]

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3189b03) 66.76% compared to head (c143b3c) 66.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##              2.x    #1708   +/-   ##
=======================================
  Coverage   66.76%   66.76%           
=======================================
  Files          93       93           
  Lines        2353     2353           
  Branches      311      311           
=======================================
  Hits         1571     1571           
  Misses        705      705           
  Partials       77       77           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cwperks cwperks merged commit 4019aa1 into opensearch-project:2.x Dec 26, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants