Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding testing info do DEVELOPER_GUIDE.md #1554

Merged
merged 4 commits into from
Aug 18, 2023

Conversation

samuelcostae
Copy link
Contributor

Description

Adding details to testing section of developer_guide.br , referencing the OS Dashboards testing project

Category

Documentation

Why these changes are required?

Missing information on Docs.

What is the old behavior before changes and new behavior after changes?

Issues Resolved

Testing

Manual Review

Check List

  • New functionality includes testing
  • New functionality has been documented
  • [x ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #1554 (3c4168f) into main (20ba268) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1554   +/-   ##
=======================================
  Coverage   66.06%   66.06%           
=======================================
  Files          93       93           
  Lines        2328     2328           
  Branches      310      310           
=======================================
  Hits         1538     1538           
  Misses        722      722           
  Partials       68       68           

AMoo-Miki and others added 2 commits August 16, 2023 13:17
Copy link
Member

@cwperks cwperks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @samuelcostae! This looks good to me. Left 2 small comments.

DEVELOPER_GUIDE.md Outdated Show resolved Hide resolved
DEVELOPER_GUIDE.md Outdated Show resolved Hide resolved
@samuelcostae
Copy link
Contributor Author

Thank you @samuelcostae! This looks good to me. Left 2 small comments.

Added the suggested changes

@samuelcostae
Copy link
Contributor Author

samuelcostae commented Aug 17, 2023

@scrawfor99 @peternied Could one of you also review this PR?

@DarshitChanpura DarshitChanpura merged commit 8f15188 into opensearch-project:main Aug 18, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants