Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.8] Fixing dynamic tenancy changes for issues 1412 (#1419) #1459

Conversation

DarshitChanpura
Copy link
Member

Backports #1419

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* Fixing dynamic tenancy changes for opensearchdasbhoard.yaml

Signed-off-by: Abhi Kalra <[email protected]>
Co-authored-by: Abhi Kalra <[email protected]>
Co-authored-by: Stephen Crawford <[email protected]>
(cherry picked from commit c4e6c37)
Signed-off-by: Darshit Chanpura <[email protected]>
@DarshitChanpura
Copy link
Member Author

Closing in lieu of #1457

@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Merging #1459 (1e1ebc1) into 2.8 (920e6eb) will decrease coverage by 0.05%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##              2.8    #1459      +/-   ##
==========================================
- Coverage   65.51%   65.47%   -0.05%     
==========================================
  Files          93       93              
  Lines        2294     2297       +3     
  Branches      307      313       +6     
==========================================
+ Hits         1503     1504       +1     
- Misses        723      725       +2     
  Partials       68       68              
Impacted Files Coverage Δ
...s/configuration/panels/tenant-list/tenant-list.tsx 3.44% <50.00%> (+3.44%) ⬆️
public/plugin.ts 12.69% <50.00%> (-0.21%) ⬇️
public/apps/account/account-nav-button.tsx 63.88% <100.00%> (ø)
...ps/configuration/panels/tenant-list/manage_tab.tsx 69.12% <100.00%> (ø)

@RyanL1997
Copy link
Collaborator

Let's reopen it, to see which one pass the test first so that we can merge it asap.

@RyanL1997
Copy link
Collaborator

Closing this one, sorry for the confusions but it seems like these versions are not for 2.8 https://github.com/opensearch-project/security-dashboards-plugin/pull/1459/files#diff-b6d8f4eded54754091348620a504858aa34db8947921abddddc018c61eb87a9cR12-R14

@RyanL1997 RyanL1997 closed this May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants