Ignore feature tests that cannot execute in gjthub CI. #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt
requested review from
amsiglan,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90,
eirsep,
jowg-amazon,
engechas,
goyamegh and
riysaxen-amzn
as code owners
eirsep
approved these changes
Jul 1, 2024
eirsep
merged commit 4adc585
into
opensearch-project:feature/threat_intel
2 checks passed
jowg-amazon
pushed a commit
to jowg-amazon/security-analytics
that referenced
this pull request
Jul 2, 2024
Signed-off-by: AWSHurneyt <[email protected]>
jowg-amazon
pushed a commit
to jowg-amazon/security-analytics
that referenced
this pull request
Jul 2, 2024
Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As mentioned in #1098 (comment), the
TestS3ConnectionRestIT, andSATIFSourceConfigRestApiITtests cannot currently be executed via github CI as they require additional input params.Will discuss onboarding to github secrets with the build team to securely provide those params, and will raise a separate PR to remove the
@Ignoreannotations.Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.