Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes for threat intel, duplicate findings, and breadcrumbs path #1176

Merged
merged 5 commits into from
Oct 2, 2024

Conversation

jowg-amazon
Copy link
Contributor

Description

  • Fixes the spacing for threat intel sources
Screenshot 2024-10-01 at 2 39 52 PM
  • Fixes the alienvault source details page crash
    Before:
Screenshot 2024-10-01 at 2 48 34 PM

After:
Screenshot 2024-10-01 at 2 50 42 PM

  • Fixes the threat intel view all all url crash
    Before:
Screenshot 2024-10-01 at 2 48 53 PM

After:
Screenshot 2024-10-01 at 2 51 31 PM

  • Fixes the Security Analytics breadcrumb link crash so it links to the overview page now
    Before:
Screenshot 2024-10-01 at 2 48 06 PM

After:
Screenshot 2024-10-01 at 2 41 37 PM

  • Fixes duplicate findings showing up on the dashboard

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@jowg-amazon jowg-amazon changed the title Frontend bug fixes Bug fixes for threat intel, duplicate findings, and breadcrumbs path Oct 1, 2024
@jowg-amazon
Copy link
Contributor Author

Cypress tests passed locally

       Spec                                              Tests  Passing  Failing  Pending  Skipped  
  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ ✔  1_detectors.spec.js                      01:57       14       14        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  2_rules.spec.js                          02:13       17       17        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  3_alerts.spec.js                         02:54        7        7        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  4_findings.spec.js                       01:44        7        6        -        1        - │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘
    ✔  All specs passed!                        08:49       45       44        -        1        -  

@AWSHurneyt AWSHurneyt merged commit 0ce91fb into opensearch-project:main Oct 2, 2024
7 of 10 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 2, 2024
…1176)

* fix spacing for threat intel

Signed-off-by: Joanne Wang <[email protected]>

* fix alienvault source details page crash

Signed-off-by: Joanne Wang <[email protected]>

* fix threat intel findings widget view view all url crash

Signed-off-by: Joanne Wang <[email protected]>

* fix security analtyics breadcrumbs link path crash

Signed-off-by: Joanne Wang <[email protected]>

* fix duplicate findings

Signed-off-by: Joanne Wang <[email protected]>

---------

Signed-off-by: Joanne Wang <[email protected]>
(cherry picked from commit 0ce91fb)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan pushed a commit that referenced this pull request Oct 3, 2024
…1176) (#1177)

* fix spacing for threat intel



* fix alienvault source details page crash



* fix threat intel findings widget view view all url crash



* fix security analtyics breadcrumbs link path crash



* fix duplicate findings



---------


(cherry picked from commit 0ce91fb)

Signed-off-by: Joanne Wang <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants