Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider contractors and students as external in metrics. #79

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Mar 25, 2024

Description

Consider contractors and students as external in metrics.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 43.93939% with 37 lines in your changes are missing coverage. Please review.

Project coverage is 75.98%. Comparing base (25c77e2) to head (4a7a5d2).

Files Patch % Lines
lib/github/buckets.rb 0.00% 11 Missing ⚠️
lib/github/repos.rb 23.07% 10 Missing ⚠️
lib/github/data.rb 64.00% 9 Missing ⚠️
lib/github/maintainers.rb 44.44% 5 Missing ⚠️
lib/github/contributors.rb 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
- Coverage   77.47%   75.98%   -1.49%     
==========================================
  Files          57       57              
  Lines         870      891      +21     
==========================================
+ Hits          674      677       +3     
- Misses        196      214      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dblock dblock merged commit ad44392 into opensearch-project:main Mar 25, 2024
4 of 6 checks passed
@dblock dblock deleted the consider-contributors branch March 25, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant