Remove usage of deprecated "master" APIs #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All usages have been replaced with the "cluster manager" variants. Signed-off-by: Andrew Ross <[email protected]>
andrross
requested review from
praveensameneni,
khushbr,
ansjcy,
goyamegh,
getsaurabh02,
sbcd90 and
sgup432
as code owners
khushbr
approved these changes
Sep 5, 2023
ansjcy
approved these changes
Sep 5, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 5, 2023
All usages have been replaced with the "cluster manager" variants. Signed-off-by: Andrew Ross <[email protected]> (cherry picked from commit 7a6f789)
khushbr
pushed a commit
that referenced
this pull request
Sep 5, 2023
All usages have been replaced with the "cluster manager" variants. Signed-off-by: Andrew Ross <[email protected]> (cherry picked from commit 7a6f789) Co-authored-by: Andrew Ross <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All usages have been replaced with the "cluster manager" variants.
Additional context
I'm looking at removing MasterService in the core repo and this appears to be the only remaining reference outside of core. Note the build appears to be broken on main (?) but this commit can be cleanly cherry picked on to the 2.x branch where it will compile successfully.
Here is the closed issue that refers to removing deprecated APIs: #152
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.