Update RestController constructor for tests. #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Filip Drobnjakovic <[email protected]>
Tjofil
requested review from
praveensameneni,
khushbr,
ansjcy,
goyamegh,
getsaurabh02,
sbcd90 and
sgup432
as code owners
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #440 +/- ##
============================================
+ Coverage 71.95% 72.10% +0.15%
- Complexity 374 375 +1
============================================
Files 44 44
Lines 2560 2560
Branches 173 173
============================================
+ Hits 1842 1846 +4
+ Misses 609 606 -3
+ Partials 109 108 -1 |
khushbr
approved these changes
May 4, 2023
ansjcy
approved these changes
May 4, 2023
khushbr
pushed a commit
to khushbr/performance-analyzer
that referenced
this pull request
May 17, 2023
Signed-off-by: Filip Drobnjakovic <[email protected]>
khushbr
added a commit
that referenced
this pull request
May 17, 2023
* Update RestController constructor for tests. (#440) Signed-off-by: Filip Drobnjakovic <[email protected]> * Fixing ShardStateCollector; impacted by core refactoring Signed-off-by: Khushboo Rajput <[email protected]> * [Collector] Adding Latency and Error service metrics (#442) * [Collector] Adding Latency and Error service metrics Signed-off-by: Khushboo Rajput <[email protected]> * Removing fastdoubleparser-LICENSE.txt and fastdoubleparser-NOTICE.txt Signed-off-by: Khushboo Rajput <[email protected]> --------- Signed-off-by: Khushboo Rajput <[email protected]> * License changes Signed-off-by: Khushboo Rajput <[email protected]> --------- Signed-off-by: Filip Drobnjakovic <[email protected]> Signed-off-by: Khushboo Rajput <[email protected]> Co-authored-by: Filip Drobnjaković <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to opensearch-project/OpenSearch#7246, added dummy
IdentityServiceobjects intoResControllerconstructors used in tests.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.