Compress searchbar #1426
Merged
Compress searchbar #1426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miki <[email protected]>
….toOpenSearchQuery and Query.toOpenSearchQueryString Also: * Fix naming conventions in OuiSearchBar code and docs Signed-off-by: Miki <[email protected]>
AMoo-Miki
requested review from
bandinib-amzn,
ashwin-pc,
joshuarrrr and
virajsanghvi
as code owners
Signed-off-by: Miki <[email protected]>
AMoo-Miki
force-pushed
the
compress-searchbar
branch
from
d1c9815
to
1733eb3
Compare
|
looks like search bar test snapshot needs to be updated |
virajsanghvi
approved these changes
Oct 2, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 2, 2024
* Reduce the gap between the elements of a compressed OuiSearchBar Signed-off-by: Miki <[email protected]> * Deprecate Query.toESQuery and Query.toESQueryString in favor of Query.toOpenSearchQuery and Query.toOpenSearchQueryString Also: * Fix naming conventions in OuiSearchBar code and docs Signed-off-by: Miki <[email protected]> * Update CHANGELOG Signed-off-by: Miki <[email protected]> --------- Signed-off-by: Miki <[email protected]> (cherry picked from commit 078a904) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
virajsanghvi
pushed a commit
that referenced
this pull request
Oct 3, 2024
* Reduce the gap between the elements of a compressed OuiSearchBar Signed-off-by: Miki <[email protected]> * Deprecate Query.toESQuery and Query.toESQueryString in favor of Query.toOpenSearchQuery and Query.toOpenSearchQueryString Also: * Fix naming conventions in OuiSearchBar code and docs Signed-off-by: Miki <[email protected]> * Update CHANGELOG Signed-off-by: Miki <[email protected]> --------- Signed-off-by: Miki <[email protected]> (cherry picked from commit 078a904) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
Check List
yarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.