Consume the className prop in OuiSearchBar
#1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMoo-Miki
requested review from
rednaksi91,
bandinib-amzn,
ashwin-pc,
joshuarrrr,
andreymyssak,
SergeyMyssak and
virajsanghvi
as code owners
ashwin-pc
approved these changes
Sep 3, 2024
Comment on lines
+103
to
+107
| // @deprecated This property has never been consumed despite being defined | ||
| 'aria-label'?: string; | ||
|
|
||
| // @deprecated This property has never been consumed despite being defined | ||
| 'data-test-subj'?: string; |
There was a problem hiding this comment.
do we still have a data-test-subj that we can use? for our tests?
There was a problem hiding this comment.
the actual component inside does and that one has its own test id. These two have never been attached to anything.
AMoo-Miki
force-pushed
the
prop-classname-searchbar
branch
from
a570f7e
to
30b45f2
Compare
Also: * deprecate `aria-label` and `data-test-subj` which have never been consumed despite being defined Signed-off-by: Miki <[email protected]>
AMoo-Miki
force-pushed
the
prop-classname-searchbar
branch
from
30b45f2
to
580f9d4
Compare
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
Also: * deprecate `aria-label` and `data-test-subj` which have never been consumed despite being defined Signed-off-by: Miki <[email protected]> (cherry picked from commit 9e8cf07) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
AMoo-Miki
pushed a commit
that referenced
this pull request
Sep 5, 2024
Also: * deprecate `aria-label` and `data-test-subj` which have never been consumed despite being defined Signed-off-by: Miki <[email protected]> (cherry picked from commit 9e8cf07) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Consume the
classNameprop in OuiSearchBarAlso:
aria-labelanddata-test-subjwhich have never been consumed despite being definedIssues Resolved
Fixes #1343
Check List
yarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.