Add Compressed form components, color-picker, and combobox, and small button components and filter-button #1301
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces special variants of the necessary components with fixed size or density properties, in order to mitigate potential complexities and conflicts that could arise from attempting to revert size and density modifications directly within the original components, especially as the codebase evolves over time.
Long version
Modifications to form elements and buttons without explicit sizing attributes are being implemented in OSD to optimize space utilization and enhance the overall aesthetic appeal. These adjustments involve setting
size="s"
orcompressed={true}
on the elements. However, a comprehensive review of OUI's typography and sizing conventions is scheduled, which could potentially necessitate the reversal of these modifications.As time progresses, reversal of the thousands of size and density modifications will become increasingly intricate due to the accumulation of neighboring code resulting in conflicts that must be addressed. Furthermore, the pre-existing sizing and density properties will become indistinguishable from the newly implemented modifications, compounding the complexity of the reversal task.
This PR introduces special variants of the necessary components with fixed size or density properties. OSD and plugins will use these variants which are marked
@internal
to indicate that they are not meant for public consumption. This strategy ensures that if a decision is made to revert to the previous sizing and density specifications, the process of identifying and modifying the components will be more straightforward. Instead of having to search through and update individual size and density properties scattered across numerous instances of the original components, the instances of the special variants can be located and replaced more efficiently. If the typography revisit does not necessitate a reversal, transitioning the special variants to utilize the original components with the desired size and density properties would be a straightforward process as well.Check List
yarn lint
yarn test-unit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.