Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 1.x] [Enhance] Add Explanation for external Prop in OuiLink #1300

Merged
merged 1 commit into from
Jul 17, 2024
Merged

[Backport 1.x] [Enhance] Add Explanation for external Prop in OuiLink #1300

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src-docs/src/views/link/link.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

import React from 'react';

import { OuiCode, OuiLink, OuiText } from '../../../../src/components';
import { OuiCode, OuiLink, OuiText, OuiIcon } from '../../../../src/components';

export default () => (
<OuiText>
Expand All @@ -28,7 +28,9 @@ export default () => (
<OuiLink href="https://oui.opensearch.org/latest/" external>
link
</OuiLink>{' '}
has the <OuiCode>external</OuiCode> prop set to true.
has the <OuiCode>external</OuiCode> prop set to true. A pop-out icon{' '}
<OuiIcon type="popout" size="s" /> will be automatically rendered to
indicate that it leads to an external resource.
</p>
<p>
This link is actually a <OuiLink onClick={() => {}}>button</OuiLink> with
Expand Down
Loading