Add sourceQuery in metadata cache #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sean Kao <[email protected]>
seankao-az
commented
Dec 11, 2024
| "metadataCacheVersion", | ||
| FlintMetadataCache.metadataCacheVersion), | ||
| Entry("lastRefreshTime", testLastRefreshCompleteTime)) | ||
| properties should not contain key("refreshInterval") |
There was a problem hiding this comment.
change because it's actually what this case is supposed to test. Test for other fields is covered in other cases
Signed-off-by: Sean Kao <[email protected]>
Signed-off-by: Sean Kao <[email protected]>
seankao-az
requested review from
dai-chen,
mengweieric,
penghuo,
anirudha,
kaituo,
YANG-DB,
noCharger,
LantaoJin and
ykmr1224
as code owners
dai-chen
approved these changes
Dec 12, 2024
...ala/org/opensearch/flint/spark/metadatacache/FlintOpenSearchMetadataCacheWriterITSuite.scala
Show resolved
Hide resolved
| */ | ||
| private def buildPropertiesMap(metadata: FlintMetadata): util.Map[String, AnyRef] = { | ||
| val metadataCacheProperties = FlintMetadataCache(metadata).toMap | ||
| private def mergeMapping( |
There was a problem hiding this comment.
just wonder is it easier to do merge at existingMapping._meta.properties in place directly?
Signed-off-by: Sean Kao <[email protected]>
seankao-az
added a commit
to seankao-az/opensearch-spark
that referenced
this pull request
Dec 17, 2024
* add sourceQuery in metadata cache Signed-off-by: Sean Kao <[email protected]> * preserve index mapping content when updating cache Signed-off-by: Sean Kao <[email protected]> * syntax and comment Signed-off-by: Sean Kao <[email protected]> * merge index mapping in place Signed-off-by: Sean Kao <[email protected]> --------- Signed-off-by: Sean Kao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For MV index, add a query string field into metadata cache.
In addition, preserves content in index mapping when updating the cache.
Before:
FlintOpenSearchMetadataCacheWritertries to serialize theFlintMetadataby itself, ignoring what's currently inside index mapping.After: No longer tries to serialize
FlintMetadatainto the json string used for update index mapping. Instead, read the current index mapping, and add the required cache fields into it.Related Issues
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.