-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add retryable AOSS HTTP response #951
Merged
seankao-az
merged 5 commits into
opensearch-project:main
from
seankao-az:retry-update-mapping
Dec 9, 2024
Merged
Add retryable AOSS HTTP response #951
seankao-az
merged 5 commits into
opensearch-project:main
from
seankao-az:retry-update-mapping
Dec 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seankao-az
changed the title
Add retryable response message
Add retryable HTTP response messages
Nov 27, 2024
seankao-az
force-pushed
the
retry-update-mapping
branch
3 times, most recently
from
November 27, 2024 03:36
3b6e39b
to
54c426f
Compare
dai-chen
reviewed
Nov 27, 2024
flint-core/src/main/scala/org/opensearch/flint/core/http/FlintRetryOptions.java
Outdated
Show resolved
Hide resolved
seankao-az
changed the title
Add retryable HTTP response messages
Add retryable AOSS HTTP response
Dec 4, 2024
seankao-az
force-pushed
the
retry-update-mapping
branch
from
December 4, 2024 23:37
309bcd7
to
b9e5aad
Compare
seankao-az
requested review from
mengweieric,
vmmusings,
penghuo,
anirudha,
kaituo,
YANG-DB,
noCharger,
LantaoJin and
ykmr1224
as code owners
December 4, 2024 23:37
seankao-az
force-pushed
the
retry-update-mapping
branch
from
December 4, 2024 23:43
b9e5aad
to
bd43c66
Compare
dai-chen
reviewed
Dec 4, 2024
flint-core/src/main/scala/org/opensearch/flint/core/http/handler/HttpAOSSResultPredicate.java
Outdated
Show resolved
Hide resolved
dai-chen
approved these changes
Dec 5, 2024
Shall we backport to 0.6? Is 0.6.1 the next release? |
yes |
Signed-off-by: Sean Kao <[email protected]>
Signed-off-by: Sean Kao <[email protected]>
Signed-off-by: Sean Kao <[email protected]>
Signed-off-by: Sean Kao <[email protected]>
Signed-off-by: Sean Kao <[email protected]>
seankao-az
force-pushed
the
retry-update-mapping
branch
from
December 9, 2024 18:05
e6b4972
to
1942b80
Compare
rebased for the sbt error in CI |
dai-chen
approved these changes
Dec 9, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
* add retryable response message Signed-off-by: Sean Kao <[email protected]> * check retryable response only if 400 Signed-off-by: Sean Kao <[email protected]> * add handler for aoss only Signed-off-by: Sean Kao <[email protected]> * edit comment Signed-off-by: Sean Kao <[email protected]> * bugfix: aoss result predicate not used Signed-off-by: Sean Kao <[email protected]> --------- Signed-off-by: Sean Kao <[email protected]> (cherry picked from commit 5720e54) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 10, 2024
* add retryable response message Signed-off-by: Sean Kao <[email protected]> * check retryable response only if 400 Signed-off-by: Sean Kao <[email protected]> * add handler for aoss only Signed-off-by: Sean Kao <[email protected]> * edit comment Signed-off-by: Sean Kao <[email protected]> * bugfix: aoss result predicate not used Signed-off-by: Sean Kao <[email protected]> --------- Signed-off-by: Sean Kao <[email protected]> (cherry picked from commit 5720e54) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
seankao-az
pushed a commit
that referenced
this pull request
Dec 10, 2024
* add retryable response message * check retryable response only if 400 * add handler for aoss only * edit comment * bugfix: aoss result predicate not used --------- (cherry picked from commit 5720e54) Signed-off-by: Sean Kao <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kenrickyap
pushed a commit
to Bit-Quill/opensearch-spark
that referenced
this pull request
Dec 11, 2024
* add retryable response message Signed-off-by: Sean Kao <[email protected]> * check retryable response only if 400 Signed-off-by: Sean Kao <[email protected]> * add handler for aoss only Signed-off-by: Sean Kao <[email protected]> * edit comment Signed-off-by: Sean Kao <[email protected]> * bugfix: aoss result predicate not used Signed-off-by: Sean Kao <[email protected]> --------- Signed-off-by: Sean Kao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add retryable AOSS http response.
Please check the linked issue.
For AOSS, retry if status code is 400 and error message contains "resource_already_exists_exception"
Related Issues
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.