Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethrow exception in writeData() #943

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

noCharger
Copy link
Collaborator

@noCharger noCharger commented Nov 22, 2024

Description

Rethrow exception in writeData() so that this can be recorded at top level

      try {
        dataToWrite.foreach(df => writeDataFrameToOpensearch(df, resultIndex, osClient))
      } catch {
        case t: Throwable =>
          throwableHandler.recordThrowable(
            s"Failed to write to result index. originalError='${throwableHandler.error}'",
            t)
      }

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@noCharger noCharger merged commit 31fae14 into opensearch-project:main Nov 22, 2024
6 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 22, 2024
Signed-off-by: Louis Chu <[email protected]>
(cherry picked from commit 31fae14)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 22, 2024
Signed-off-by: Louis Chu <[email protected]>
(cherry picked from commit 31fae14)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
noCharger pushed a commit that referenced this pull request Nov 22, 2024
(cherry picked from commit 31fae14)

Signed-off-by: Louis Chu <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
saranrajnk pushed a commit to saranrajnk/opensearch-spark that referenced this pull request Dec 3, 2024
…roject#945)

(cherry picked from commit 31fae14)

Signed-off-by: Louis Chu <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kenrickyap pushed a commit to Bit-Quill/opensearch-spark that referenced this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants