[Backport 0.6] Add metrics for successful/failed Spark index creation #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Add index creation metrics Signed-off-by: Simeon Widdis <[email protected]> * Update emit metric function location Signed-off-by: Simeon Widdis <[email protected]> * Apply scalafmt Signed-off-by: Simeon Widdis <[email protected]> * revert FlintSparkIndexFactory metrics emission Signed-off-by: Simeon Widdis <[email protected]> * Update OS client to emit metrics Signed-off-by: Simeon Widdis <[email protected]> * Fix index kind detection Signed-off-by: Simeon Widdis <[email protected]> * Remove cumbersome with() method Signed-off-by: Simeon Widdis <[email protected]> * Revert the void change Signed-off-by: Simeon Widdis <[email protected]> * Make the code branchless Signed-off-by: Simeon Widdis <[email protected]> * Add default case to switches Signed-off-by: Simeon Widdis <[email protected]> * Apply PR feedback Signed-off-by: Simeon Widdis <[email protected]> --------- Signed-off-by: Simeon Widdis <[email protected]> (cherry picked from commit 6f37b2d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
dai-chen,
mengweieric,
vmmusings,
penghuo,
seankao-az,
anirudha,
kaituo,
YANG-DB,
noCharger,
LantaoJin and
ykmr1224
as code owners
ykmr1224
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 6f37b2d from #837.