Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics for query types #891

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

ykmr1224
Copy link
Collaborator

@ykmr1224 ykmr1224 commented Nov 12, 2024

Description

  • Add metrics for query types
  • drop won't be emitted in current flow since it is be executed at SQL plugin side.

Metrics emitted by tests:
Metrics-CloudWatch-us-east-1-11-12-2024_09_11_AM

Related Issues

n/a

Check List

  • Updated documentation (docs/ppl-lang/README.md)
  • Implemented unit tests
  • Implemented tests for combination with other commands
  • New added source code should include a copyright header
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Tomoyuki Morita <[email protected]>
Copy link
Collaborator

@seankao-az seankao-az left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason for distinguishing between create auto refresh and create manual refresh index?
do we want to also count alter to auto and alter to manual separately?

@ykmr1224
Copy link
Collaborator Author

any reason for distinguishing between create auto refresh and create manual refresh index? do we want to also count alter to auto and alter to manual separately?

It is basically to track the usage of each type of query. We can add more and more granular metrics, but we need to stop somewhere... We can add more when we realize we need.

@ykmr1224 ykmr1224 merged commit 9d504ea into opensearch-project:main Nov 13, 2024
6 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 13, 2024
Signed-off-by: Tomoyuki Morita <[email protected]>
(cherry picked from commit 9d504ea)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ykmr1224 pushed a commit that referenced this pull request Nov 13, 2024
(cherry picked from commit 9d504ea)

Signed-off-by: Tomoyuki Morita <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kenrickyap pushed a commit to Bit-Quill/opensearch-spark that referenced this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants