Support parenthesized expression in filter #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lantao Jin <[email protected]>
Signed-off-by: Lantao Jin <[email protected]>
LantaoJin
requested review from
dai-chen,
mengweieric,
vmmusings,
penghuo,
seankao-az,
anirudha,
kaituo,
YANG-DB,
noCharger and
ykmr1224
as code owners
YANG-DB
reviewed
Nov 12, 2024
| @@ -467,4 +467,33 @@ class FlintSparkPPLFiltersITSuite | |||
| val expectedPlan = Project(Seq(UnresolvedAttribute("state")), filter) | |||
| comparePlans(logicalPlan, expectedPlan, checkAnalysis = false) | |||
| } | |||
|
|
|||
| test("test parenthesis in filter") { | |||
There was a problem hiding this comment.
@LantaoJin can u plz add a nested parenthesis test case ?
There was a problem hiding this comment.
in addition - can u plz add a correspondent logical unit test under the PPL*** relevant tests ?
YANG-DB
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
@LantaoJin Looks good - just maybe add an additional nested parentheses test case ?
Signed-off-by: Lantao Jin <[email protected]>
YANG-DB
approved these changes
Nov 13, 2024
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/opensearch-spark/backport-0.6 0.6
# Navigate to the new working tree
pushd ../.worktrees/opensearch-spark/backport-0.6
# Create a new branch
git switch --create backport/backport-888-to-0.6
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a80aa04b9bbadfe68a3ed0ff59c3edce5251aac6
# Push it to GitHub
git push --set-upstream origin backport/backport-888-to-0.6
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/opensearch-spark/backport-0.6Then, create a pull request where the |
LantaoJin
added a commit
to LantaoJin/opensearch-spark
that referenced
this pull request
Nov 14, 2024
(cherry picked from commit a80aa04)
LantaoJin
added a commit
to LantaoJin/opensearch-spark
that referenced
this pull request
Nov 14, 2024
(cherry picked from commit a80aa04) Signed-off-by: Lantao Jin <[email protected]>
LantaoJin
added a commit
that referenced
this pull request
Nov 14, 2024
(cherry picked from commit a80aa04) Signed-off-by: Lantao Jin <[email protected]>
kenrickyap
pushed a commit
to Bit-Quill/opensearch-spark
that referenced
this pull request
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Parenthesized expression cannot work as expected in filter:
source = $testTable | where (country = 'Canada' or age > 60) and age < 25 | fields name, age, countryfailed in parser.Related Issues
Resolves #887
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.