-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sample
parameter to top
& rare
command
#879
Closed
YANG-DB
wants to merge
12
commits into
opensearch-project:main
from
YANG-DB:add-sample-top-rare-command
Closed
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
8589188
add sample option flag to sample a percentage of the table data inste…
YANG-DB 6e9d485
add support for agg sample context
YANG-DB 793c1ad
add sample class
YANG-DB a9adaa7
add sample class
YANG-DB dce23d9
add sample tests
YANG-DB 1a34544
update visitor child method on the catalyst plan visitor
YANG-DB a4992e8
add documentation and fix IT tests
YANG-DB 870d434
update scala fmt
YANG-DB 2197eab
fix explain visitChild error
YANG-DB 1f2ae52
Merge branch 'main' into add-sample-top-rare-command
YANG-DB 7c63446
remove non relevant tests from this PR
YANG-DB 09b6bda
update scala fmt issue
YANG-DB File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,6 +24,7 @@ SORT: 'SORT'; | |
EVAL: 'EVAL'; | ||
HEAD: 'HEAD'; | ||
TOP: 'TOP'; | ||
SAMPLE: 'SAMPLE'; | ||
RARE: 'RARE'; | ||
PARSE: 'PARSE'; | ||
METHOD: 'METHOD'; | ||
|
@@ -79,6 +80,7 @@ DESC: 'DESC'; | |
DATASOURCES: 'DATASOURCES'; | ||
USING: 'USING'; | ||
WITH: 'WITH'; | ||
PERCENT: 'PERCENT'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. SAMPLE and PERCENT should be added to |
||
|
||
// FIELD KEYWORDS | ||
AUTO: 'AUTO'; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I strongly suggest to add some IT cases for top/rare with sample in complex join and subquery query.