Refactor CatalystQueryPlanVisitor into distinct Plan & Expression visitors
#852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t into two distinct visitors: Plan Visitor ( which extends AbstractNodeVisitor<LogicalPlan, CatalystPlanContext> ) Expression Visitor (which extends AbstractNodeVisitor<Expression, CatalystPlanContext>) This would match the existing PPL AST visitors composition: AstBuilder ( which extends OpenSearchPPLParserBaseVisitor) AstExpressionBuilder ( which extends OpenSearchPPLParserBaseVisitor ) In addition unify the ppl utils classes to match one of the following naming: *Transformer - transforms PPL (logical) expressions into Spark (logical) expressions *Utils - utility class Signed-off-by: YANGDB <[email protected]>
YANG-DB
requested review from
dai-chen,
rupal-bq,
mengweieric,
vmmusings,
penghuo,
seankao-az,
anirudha,
kaituo,
noCharger,
LantaoJin and
ykmr1224
as code owners
YANG-DB
changed the title
CatalystQueryPlanVisitor into Plan & Expression visitor
YANG-DB
changed the title
CatalystQueryPlanVisitor into Plan & Expression visitorCatalystQueryPlanVisitor into Plan & Expression visitors
YANG-DB
changed the title
CatalystQueryPlanVisitor into Plan & Expression visitorsCatalystQueryPlanVisitor into distinct Plan & Expression visitors
LantaoJin
reviewed
Oct 31, 2024
ppl-spark-integration/src/main/java/org/opensearch/sql/ppl/CatalystQueryPlanVisitor.java
Show resolved
Hide resolved
Signed-off-by: YANGDB <[email protected]>
LantaoJin
approved these changes
Oct 31, 2024
# Conflicts: # ppl-spark-integration/src/main/java/org/opensearch/sql/ppl/CatalystQueryPlanVisitor.java
Signed-off-by: YANGDB <[email protected]>
Signed-off-by: YANGDB <[email protected]>
kenrickyap
pushed a commit
to Bit-Quill/opensearch-spark
that referenced
this pull request
Dec 11, 2024
…isitors (opensearch-project#852) * We would like to refactor the CatalystQueryPlanVisitor and separate it into two distinct visitors: Plan Visitor ( which extends AbstractNodeVisitor<LogicalPlan, CatalystPlanContext> ) Expression Visitor (which extends AbstractNodeVisitor<Expression, CatalystPlanContext>) This would match the existing PPL AST visitors composition: AstBuilder ( which extends OpenSearchPPLParserBaseVisitor) AstExpressionBuilder ( which extends OpenSearchPPLParserBaseVisitor ) In addition unify the ppl utils classes to match one of the following naming: *Transformer - transforms PPL (logical) expressions into Spark (logical) expressions *Utils - utility class Signed-off-by: YANGDB <[email protected]> * update the AstBuilder ctor Signed-off-by: YANGDB <[email protected]> * resolve latest merge conflicts Signed-off-by: YANGDB <[email protected]> --------- Signed-off-by: YANGDB <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need to refactor the
CatalystQueryPlanVisitorand separate it into two distinct visitors:extends AbstractNodeVisitor<LogicalPlan, CatalystPlanContext>)extends AbstractNodeVisitor<Expression, CatalystPlanContext>)This would match the existing PPL AST visitors composition:
extends OpenSearchPPLParserBaseVisitor)extends OpenSearchPPLParserBaseVisitor)In addition unify the ppl utils classes to match one of the following naming:
*Transformer - transforms PPL (logical) expressions into Spark (logical) expressions*Utils - utility classRelated Issues
#851
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.