Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.5-nexus] Fix ci for scheduler on nexus branch #845

Merged

Conversation

seankao-az
Copy link
Collaborator

Description

Test related to external scheduler in this branch were failing for:

2024-10-30T19:12:11.4327415Z 24/10/30 19:12:11 ERROR OpenSearchAsyncQueryScheduler: Error creating index : .async-query-scheduler
2024-10-30T19:12:11.4329032Z java.lang.NoSuchFieldError: USE_FAST_DOUBLE_PARSER
2024-10-30T19:12:11.4330525Z 	at com.fasterxml.jackson.dataformat.yaml.YAMLParser._parseNumericValue(YAMLParser.java:1055)
2024-10-30T19:12:11.4332267Z 	at com.fasterxml.jackson.core.base.ParserBase.getNumberType(ParserBase.java:660)
2024-10-30T19:12:11.4333764Z 	at com.fasterxml.jackson.core.JsonGenerator._copyCurrentContents(JsonGenerator.java:2616)
2024-10-30T19:12:11.4335439Z 	at com.fasterxml.jackson.core.JsonGenerator.copyCurrentStructure(JsonGenerator.java:2547)
2024-10-30T19:12:11.4337495Z 	at org.opensearch.common.xcontent.json.JsonXContentGenerator.copyCurrentStructure(JsonXContentGenerator.java:418)
2024-10-30T19:12:11.4339633Z 	at org.opensearch.common.xcontent.json.JsonXContentGenerator.writeRawField(JsonXContentGenerator.java:361)
2024-10-30T19:12:11.4341505Z 	at org.opensearch.common.xcontent.XContentBuilder.rawField(XContentBuilder.java:1000)
2024-10-30T19:12:11.4343400Z 	at org.opensearch.client.indices.CreateIndexRequest.innerToXContent(CreateIndexRequest.java:368)
2024-10-30T19:12:11.4347630Z 	at org.opensearch.client.indices.CreateIndexRequest.toXContent(CreateIndexRequest.java:356)
2024-10-30T19:12:11.4349317Z 	at org.opensearch.common.xcontent.XContentHelper.toXContent(XContentHelper.java:476)
2024-10-30T19:12:11.4351154Z 	at org.opensearch.client.RequestConverters.createEntity(RequestConverters.java:819)
2024-10-30T19:12:11.4352673Z 	at org.opensearch.client.RequestConverters.createEntity(RequestConverters.java:814)
2024-10-30T19:12:11.4354283Z 	at org.opensearch.client.IndicesRequestConverters.createIndex(IndicesRequestConverters.java:162)
2024-10-30T19:12:11.4356349Z 	at org.opensearch.client.RestHighLevelClient.internalPerformRequest(RestHighLevelClient.java:1907)
2024-10-30T19:12:11.4358282Z 	at org.opensearch.client.RestHighLevelClient.performRequest(RestHighLevelClient.java:1894)
2024-10-30T19:12:11.4360038Z 	at org.opensearch.client.RestHighLevelClient.performRequestAndParseEntity(RestHighLevelClient.java:1858)
2024-10-30T19:12:11.4361613Z 	at org.opensearch.client.IndicesClient.create(IndicesClient.java:159)

which is compatibility issue between the Jackson YAML parser and the version of Jackson core libraries being used in this branch.

This PR convert the configuration files to JSON. JSON is natively supported and doesn't require additional parsers.
Having green CI would help with more confidence in backporting PRs.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@seankao-az seankao-az changed the title Fix ci for scheduler on nexus branch [0.5-nexus] Fix ci for scheduler on nexus branch Oct 30, 2024
Copy link
Collaborator

@noCharger noCharger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's ensure CI pass

@seankao-az seankao-az merged commit d6c8973 into opensearch-project:0.5-nexus Oct 30, 2024
5 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 30, 2024
Signed-off-by: Sean Kao <[email protected]>
(cherry picked from commit d6c8973)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants