Support IN expression in PPL #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lantao Jin <[email protected]>
LantaoJin
requested review from
dai-chen,
rupal-bq,
mengweieric,
vmmusings,
penghuo,
seankao-az,
anirudha,
kaituo,
YANG-DB,
noCharger and
ykmr1224
as code owners
YANG-DB
reviewed
Oct 28, 2024
|
|
||
| test("test IN expr in eval") { | ||
| val frame = sql(s""" | ||
| | source = $testTable | eval in = state in ('California', 'New York') | fields in |
There was a problem hiding this comment.
@LantaoJin - please add these examples to the eval doc as well
YANG-DB
approved these changes
Oct 28, 2024
Signed-off-by: Lantao Jin <[email protected]>
kenrickyap
pushed a commit
to Bit-Quill/opensearch-spark
that referenced
this pull request
Dec 11, 2024
* Support IN expression in PPL Signed-off-by: Lantao Jin <[email protected]> * add more example in eval doc Signed-off-by: Lantao Jin <[email protected]> --------- Signed-off-by: Lantao Jin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
IN expression doesn't work in PPL:
| where state in ('California', 'Florida')throws NPEThis PR targets to support following syntax:
value IN (value_list)value NOT IN (value_list)NOT value IN (value_list)to compatible with opensearch-sqlRelated Issues
Resolves #822
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.