Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fillnull command documentation #815

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Conversation

lukasz-soszynski-eliatra
Copy link
Contributor

Description

Describe what this change achieves.

Related Issues

List any issues this PR will resolve, e.g. Resolves [...].

Check List

  • Updated documentation (docs/ppl-lang/README.md)
  • Implemented unit tests
  • Implemented tests for combination with other commands
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@YANG-DB
Copy link
Member

YANG-DB commented Oct 28, 2024

@lukasz-soszynski-eliatra plz fix the DCO (contributor signed off)

Signed-off-by: Lukasz Soszynski <[email protected]>
@lukasz-soszynski-eliatra
Copy link
Contributor Author

Done

@YANG-DB
Copy link
Member

YANG-DB commented Oct 29, 2024

@lukasz-soszynski-eliatra thanks - plz add the link of the detailed doc to the main readme page here

Copy link
Member

@YANG-DB YANG-DB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add this page to the main readme ppl examples page

@lukasz-soszynski-eliatra
Copy link
Contributor Author

add this page to the main readme ppl examples page

I replaced the link to the designer documentation with the page created in the PR.

@YANG-DB YANG-DB merged commit cd730cb into opensearch-project:main Oct 29, 2024
4 checks passed
kenrickyap pushed a commit to Bit-Quill/opensearch-spark that referenced this pull request Dec 11, 2024
* Fillnull command documentation

Signed-off-by: Lukasz Soszynski <[email protected]>

* Added reference ppl-fillnull-command.md in the PPL-Example-Commands.md file.

Signed-off-by: Lukasz Soszynski <[email protected]>

---------

Signed-off-by: Lukasz Soszynski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.6 Lang:PPL Pipe Processing Language support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants