All-fields as an argument of aggregator such as count() can be resolved after other field
#814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r fields Signed-off-by: Lantao Jin <[email protected]>
LantaoJin
requested review from
dai-chen,
rupal-bq,
mengweieric,
vmmusings,
penghuo,
seankao-az,
anirudha,
kaituo,
YANG-DB,
noCharger and
ykmr1224
as code owners
LantaoJin
commented
Oct 25, 2024
| @@ -662,11 +662,7 @@ public Expression visitCorrelationMapping(FieldsMapping node, CatalystPlanContex | |||
|
|
|||
| @Override | |||
| public Expression visitAllFields(AllFields node, CatalystPlanContext context) { | |||
| // Case of aggregation step - no start projection can be added | |||
| if (context.getNamedParseExpressions().isEmpty()) { | |||
There was a problem hiding this comment.
@YANG-DB could you double confirm this fixing? IMO it's safe to remove the condition. Any case do I miss? Since I don't understand the comment of L665. Another similar case is in method visitEval(), the same condition could be removed since each eval command must convert to a project list start with *.
There was a problem hiding this comment.
Thanks! Merging to main.
LantaoJin
changed the title
All-fields as an argument of aggregator such as count() can be resolved after other fields
LantaoJin
changed the title
All-fields as an argument of aggregator such as count() can be resolved after other fieldsAll-fields as an argument of aggregator such as count() can be resolved after other field
LantaoJin
added
bug
YANG-DB
approved these changes
Oct 28, 2024
| @@ -662,11 +662,7 @@ public Expression visitCorrelationMapping(FieldsMapping node, CatalystPlanContex | |||
|
|
|||
| @Override | |||
| public Expression visitAllFields(AllFields node, CatalystPlanContext context) { | |||
| // Case of aggregation step - no start projection can be added | |||
| if (context.getNamedParseExpressions().isEmpty()) { | |||
kenrickyap
pushed a commit
to Bit-Quill/opensearch-spark
that referenced
this pull request
Dec 11, 2024
…r fields (opensearch-project#814) Signed-off-by: Lantao Jin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Count(), as iscount(*)in SQL, cannot be resolved correctly when it located after other fields resolution.For example:
Throws
But
works as expected.
Related Issues
Resolves #811
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.