Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tomo as maintainer #807

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

noCharger
Copy link
Collaborator

@noCharger noCharger commented Oct 24, 2024

Description

Add Tomo as maintainer based on commitee vote results

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Louis Chu <[email protected]>
@noCharger noCharger merged commit 34fdcab into opensearch-project:main Oct 24, 2024
4 checks passed
@noCharger
Copy link
Collaborator Author

@opensearch-project/admin Please help update the maintainers. Thx!

@gaiksaya
Copy link
Member

Added @ykmr1224 as the new maintainer.

The codeowner file is still invalid due to below errors.
image
Please take action to either add them back or move the maintainers to emeritus section if they do not wish to continue.

Thanks!

@joshuali925
Copy link
Member

you can move me to emeritus section, i haven't done much in this repo

@peterzhuamazon
Copy link
Member

peterzhuamazon commented Oct 25, 2024

you can move me to emeritus section, i haven't done much in this repo

Thanks @joshuali925 for the status update.

Also regarding this PR and codeowner file invalid issues.

We still need @mengweieric to confirm if he will continue be the maintainer, or move to emeritus.

We will then need a PR to fix codeowner file, and I will also fix the collaborator section before certain settings take effects.

Next time, please make sure to open the PR in draft mode, so admin can verify and update collaborator before the merge to avoid these kinds of issues happening again.

Thanks.

@opensearch-trigger-bot
Copy link

The backport to 0.5-nexus failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/opensearch-spark/backport-0.5-nexus 0.5-nexus
# Navigate to the new working tree
pushd ../.worktrees/opensearch-spark/backport-0.5-nexus
# Create a new branch
git switch --create backport/backport-807-to-0.5-nexus
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 34fdcab060da8bf1fc9ba9b9f8bb9a96c63be470
# Push it to GitHub
git push --set-upstream origin backport/backport-807-to-0.5-nexus
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/opensearch-spark/backport-0.5-nexus

Then, create a pull request where the base branch is 0.5-nexus and the compare/head branch is backport/backport-807-to-0.5-nexus.

seankao-az pushed a commit to seankao-az/opensearch-spark that referenced this pull request Oct 30, 2024
Signed-off-by: Louis Chu <[email protected]>
(cherry picked from commit 34fdcab)
seankao-az added a commit that referenced this pull request Oct 30, 2024
Signed-off-by: Louis Chu <[email protected]>
(cherry picked from commit 34fdcab)

Co-authored-by: Louis Chu <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 30, 2024
Signed-off-by: Louis Chu <[email protected]>
(cherry picked from commit 34fdcab)

Co-authored-by: Louis Chu <[email protected]>
(cherry picked from commit 4f8120e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot
Copy link

The backport to 0.5 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/opensearch-spark/backport-0.5 0.5
# Navigate to the new working tree
pushd ../.worktrees/opensearch-spark/backport-0.5
# Create a new branch
git switch --create backport/backport-807-to-0.5
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 34fdcab060da8bf1fc9ba9b9f8bb9a96c63be470
# Push it to GitHub
git push --set-upstream origin backport/backport-807-to-0.5
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/opensearch-spark/backport-0.5

Then, create a pull request where the base branch is 0.5 and the compare/head branch is backport/backport-807-to-0.5.

seankao-az pushed a commit to seankao-az/opensearch-spark that referenced this pull request Oct 30, 2024
Signed-off-by: Louis Chu <[email protected]>
(cherry picked from commit 34fdcab)
seankao-az pushed a commit to seankao-az/opensearch-spark that referenced this pull request Oct 30, 2024
Signed-off-by: Louis Chu <[email protected]>
(cherry picked from commit 34fdcab)
seankao-az pushed a commit that referenced this pull request Oct 30, 2024
(cherry picked from commit 34fdcab)


(cherry picked from commit 4f8120e)

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Louis Chu <[email protected]>
kenrickyap pushed a commit to Bit-Quill/opensearch-spark that referenced this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants