-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add read/write bytes metrics #803
Add read/write bytes metrics #803
Conversation
Signed-off-by: Tomoyuki Morita <[email protected]>
7ed5ff7
to
4348e58
Compare
Signed-off-by: Tomoyuki Morita <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
long timestamp; | ||
} | ||
|
||
private final List<DataPoint> dataPoints = Collections.synchronizedList(new LinkedList<>()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be a trivial question..
what could go wrong if use a regular list instead of synchronized list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As metric emit is run in separate thread, there could be concurrency issue.
flint-core/src/main/java/org/opensearch/flint/core/metrics/MetricsUtil.java
Show resolved
Hide resolved
flint-core/src/main/java/org/opensearch/flint/core/metrics/MetricsUtil.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Tomoyuki Morita <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/opensearch-spark/backport-0.5-nexus 0.5-nexus
# Navigate to the new working tree
pushd ../.worktrees/opensearch-spark/backport-0.5-nexus
# Create a new branch
git switch --create backport/backport-803-to-0.5-nexus
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2a647d43264cdcbb65f95b22c8373dee50497937
# Push it to GitHub
git push --set-upstream origin backport/backport-803-to-0.5-nexus
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/opensearch-spark/backport-0.5-nexus Then, create a pull request where the |
* Add read/write bytes metrics Signed-off-by: Tomoyuki Morita <[email protected]> * Add unit test Signed-off-by: Tomoyuki Morita <[email protected]> * Address comments Signed-off-by: Tomoyuki Morita <[email protected]> --------- Signed-off-by: Tomoyuki Morita <[email protected]> (cherry picked from commit 2a647d4)
* Add read/write bytes metrics Signed-off-by: Tomoyuki Morita <[email protected]> * Add unit test Signed-off-by: Tomoyuki Morita <[email protected]> * Address comments Signed-off-by: Tomoyuki Morita <[email protected]> --------- Signed-off-by: Tomoyuki Morita <[email protected]> (cherry picked from commit 2a647d4)
* Add read/write bytes metrics Signed-off-by: Tomoyuki Morita <[email protected]> * Add unit test Signed-off-by: Tomoyuki Morita <[email protected]> * Address comments Signed-off-by: Tomoyuki Morita <[email protected]> --------- Signed-off-by: Tomoyuki Morita <[email protected]>
Description
Sample metrics:
Related Issues
n/a
Check List
--signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.