Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support alter refresh interval on external scheduler #801

Merged
merged 4 commits into from
Oct 25, 2024

Conversation

noCharger
Copy link
Collaborator

Description

Support alter refresh interval on external scheduler

Test Scenario Expectation Result
External scheduler Alter refresh interval to value >= interval threshold Interval updated refresh interval updated successfully
External scheduler Alter refresh interval to value < interval threshold throws exception java.lang.IllegalArgumentException: Input refresh_interval is 4 Minutes, required above the interval threshold of external scheduler: 5 minutes
External scheduler Alter refresh interval to random string which can't be parsed by spark throws exception "error": """{"Message":"Fail to run query. Cause: Error parsing '4 abc' to interval, invalid unit 'abc'"}"""
External scheduler Alter to internal scheduler with refresh interval change throws exception Altering index when auto_refresh remains true and scheduler_mode is internal only allows changing: Set(scheduler_mode). Invalid options: Set(refresh_interval)
Internal scheduler Alter refresh interval throws exception Altering index when auto_refresh remains true and scheduler_mode is internal only allows changing: Set(scheduler_mode). Invalid options: Set(refresh_interval)

Issues Resolved

#704

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@noCharger noCharger enabled auto-merge (squash) October 24, 2024 00:02
@noCharger noCharger disabled auto-merge October 24, 2024 00:02
@noCharger noCharger merged commit ed1b24c into opensearch-project:main Oct 25, 2024
4 checks passed
@noCharger noCharger self-assigned this Oct 25, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 25, 2024
* Support alter refresh interval on external scheduler

Signed-off-by: Louis Chu <[email protected]>

* Add more ITs

Signed-off-by: Louis Chu <[email protected]>

---------

Signed-off-by: Louis Chu <[email protected]>
(cherry picked from commit ed1b24c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 28, 2024
* Support alter refresh interval on external scheduler

Signed-off-by: Louis Chu <[email protected]>

* Add more ITs

Signed-off-by: Louis Chu <[email protected]>

---------

Signed-off-by: Louis Chu <[email protected]>
(cherry picked from commit ed1b24c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
noCharger pushed a commit that referenced this pull request Oct 28, 2024
* Support alter refresh interval on external scheduler



* Add more ITs



---------


(cherry picked from commit ed1b24c)

Signed-off-by: Louis Chu <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
seankao-az pushed a commit that referenced this pull request Oct 30, 2024
* Support alter refresh interval on external scheduler



* Add more ITs



---------


(cherry picked from commit ed1b24c)

Signed-off-by: Louis Chu <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kenrickyap pushed a commit to Bit-Quill/opensearch-spark that referenced this pull request Dec 11, 2024
…ect#801)

* Support alter refresh interval on external scheduler

Signed-off-by: Louis Chu <[email protected]>

* Add more ITs

Signed-off-by: Louis Chu <[email protected]>

---------

Signed-off-by: Louis Chu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants