Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check list in pull request template #794

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Add check list in pull request template #794

merged 1 commit into from
Oct 21, 2024

Conversation

LantaoJin
Copy link
Member

@LantaoJin LantaoJin commented Oct 19, 2024 •
edited
Loading

Description

Add following check list in pull request template

### Check List
- [ ] Updated documentation (docs/ppl-lang/README.md)
- [ ] Implemented unit tests
- [ ] Implemented tests for combination with other commands
- [ ] Commits are signed per the DCO using `--signoff`

Issues Resolved

#793

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@LantaoJin LantaoJin added the infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. label Oct 19, 2024
@LantaoJin LantaoJin marked this pull request as ready for review October 19, 2024 04:31
dai-chen
dai-chen approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this following some template or customized by each repo? I see SQL repo has a different checklist.

@YANG-DB YANG-DB merged commit 803f773 into opensearch-project:main Oct 21, 2024
5 checks passed
kenrickyap pushed a commit to Bit-Quill/opensearch-spark that referenced this pull request Dec 11, 2024
@LantaoJin @14yapkc1
Add check list in pull request template (opensearch-project#794)
93900d3 
Signed-off-by: Lantao Jin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YANG-DB YANG-DB YANG-DB approved these changes

@dai-chen dai-chen dai-chen approved these changes

@rupal-bq rupal-bq Awaiting requested review from rupal-bq

@vamsimanohar vamsimanohar Awaiting requested review from vamsimanohar

@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

@kaituo kaituo Awaiting requested review from kaituo kaituo is a code owner

Assignees
No one assigned
Labels
infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LantaoJin @dai-chen @YANG-DB