Implement Cryptographic hash functions #788
Conversation
Gokul-Radhakrishnan
requested review from
dai-chen,
rupal-bq,
vamsimanohar,
penghuo,
seankao-az,
anirudha,
kaituo,
YANG-DB and
LantaoJin
as code owners
Signed-off-by: Gokul R <[email protected]>
Gokul-Radhakrishnan
force-pushed
the
main
branch
from
733c8a7 to
a33c0ba
Compare
There was a problem hiding this comment.
Thanks @Gokul-Radhakrishnan for your contribution
Please add an example in the example commands doc
and also add an integration test for an actual values queries from a table in the PPL integration test folder
thanks !!
|
@LantaoJin @penghuo please review and add u'r feedback |
Signed-off-by: Gokul R <[email protected]>
|
Please add some IntegTests for new functions. It could help us to verify the correctness. |
|
Will add the integration tests and update the readme file |
Signed-off-by: Gokul-Radhakrishnan <[email protected]>
Signed-off-by: Gokul R <[email protected]>
Added Integration tests |
|
@Gokul-Radhakrishnan please run |
ppl-spark-integration/src/main/java/org/opensearch/sql/ppl/utils/BuiltinFunctionTranslator.java
Show resolved
Hide resolved
Signed-off-by: Gokul R <[email protected]>
Signed-off-by: Gokul R <[email protected]>
|
@YANG-DB Integration tests were failing in the build so I fixed. Can you please approve the workflows? |
|
@LantaoJin plz review |
There was a problem hiding this comment.
@Gokul-Radhakrishnan thanks for your contribution. Merging.
| import static org.opensearch.sql.expression.function.BuiltinFunctionName.TRIM; | ||
| import static org.opensearch.sql.expression.function.BuiltinFunctionName.WEEK; | ||
| import static org.opensearch.sql.expression.function.BuiltinFunctionName.WEEK_OF_YEAR; | ||
| import static org.opensearch.sql.expression.function.BuiltinFunctionName.*; |
There was a problem hiding this comment.
Minor: I'd like to use specific static import instead of .*.
You can set Class count to use import with '*' to 99 and Name count to use static import with '*' to 99 in IDEA Settings->Editor->Code Stype->Java to prevent the auto merging.
* Implement Cryptographic hash functions Signed-off-by: Gokul R <[email protected]> * update documentation Signed-off-by: Gokul R <[email protected]> * added integration tests and updated readme file Signed-off-by: Gokul R <[email protected]> * format the code Signed-off-by: Gokul R <[email protected]> * fix integration tests Signed-off-by: Gokul R <[email protected]> --------- Signed-off-by: Gokul R <[email protected]> Signed-off-by: Gokul-Radhakrishnan <[email protected]>
Description
Used spark's builtin Cryptographic hash functions in PPL
Issues Resolved
#759
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.