Refactor datetime functions docs and IT #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lantao Jin <[email protected]>
LantaoJin
requested review from
dai-chen,
rupal-bq,
vmmusings,
penghuo,
seankao-az,
anirudha,
kaituo and
YANG-DB
as code owners
|
ping @YANG-DB |
YANG-DB
approved these changes
Oct 18, 2024
| @@ -605,31 +605,6 @@ class FlintSparkPPLBuiltinFunctionITSuite | |||
| comparePlans(logicalPlan, expectedPlan, checkAnalysis = false) | |||
| } | |||
|
|
|||
| test("test time functions - from_unixtime and unix_timestamp") { | |||
There was a problem hiding this comment.
hi @LantaoJin
why did u remove this ?
There was a problem hiding this comment.
This test was moved to FlintSparkPPLBuiltInDateTimeFunctionITSuite.
kenrickyap
pushed a commit
to Bit-Quill/opensearch-spark
that referenced
this pull request
Dec 11, 2024
Signed-off-by: Lantao Jin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://github.com/opensearch-project/opensearch-spark/blob/73a6b77c00cf4d1f6c14f6ca7ba7be37bf0916e1/docs/ppl-lang/functions/ppl-datetime.md contains many unsupported datetime functions, such as
Timedata type in SparkIssues Resolved
#786
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.