Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infrastructure] Move style check ahead of Integ test #783

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

LantaoJin
Copy link
Member

@LantaoJin LantaoJin commented Oct 16, 2024

Description

Even the current build strategy is fail-fast: false (matrix level), thanks to jobs.<job_id>.continue-on-error is false as default, style check fail out with an notification before Integ Test could be time saving.
Screenshot 2024-10-16 at 15 29 29

Issues Resolved

#782

Check List

  • Updated documentation (ppl-spark-integration/README.md)
  • Implemented unit tests
  • Implemented tests for combination with other commands
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@LantaoJin LantaoJin marked this pull request as ready for review October 16, 2024 08:09
@dai-chen dai-chen added infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. 0.6 labels Oct 16, 2024
@YANG-DB YANG-DB merged commit 73a6b77 into opensearch-project:main Oct 16, 2024
6 checks passed
kenrickyap pushed a commit to Bit-Quill/opensearch-spark that referenced this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.6 infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants