Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auth-crt lib as runtime dependency #778

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

noCharger
Copy link
Collaborator

Description

Add auth-crt lib as runtime dependency

Issues Resolved

The fat jar doesn't include auth-crt lib will cause runtime issue:

java.lang.NoClassDefFoundError: software/amazon/awssdk/authcrt/signer/AwsCrtV4aSigner

after this change:

Searching in /usr/lib/spark/jars/opensearch-spark-sql-application_2.12-latest.jar
software/amazon/awssdk/authcrt/signer/AwsCrtV4aSigner$Builder.class
software/amazon/awssdk/authcrt/signer/AwsCrtV4aSigner.class
software/amazon/awssdk/authcrt/signer/internal/DefaultAwsCrtV4aSigner$1.class
software/amazon/awssdk/authcrt/signer/internal/DefaultAwsCrtV4aSigner$BuilderImpl.class
software/amazon/awssdk/authcrt/signer/internal/DefaultAwsCrtV4aSigner.class

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Collaborator

@penghuo penghuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@noCharger noCharger self-assigned this Oct 14, 2024
@noCharger noCharger merged commit 0b106f1 into opensearch-project:main Oct 14, 2024
7 checks passed
@opensearch-trigger-bot
Copy link

The backport to 0.5-nexus failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/opensearch-spark/backport-0.5-nexus 0.5-nexus
# Navigate to the new working tree
pushd ../.worktrees/opensearch-spark/backport-0.5-nexus
# Create a new branch
git switch --create backport/backport-778-to-0.5-nexus
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0b106f184d8ea8017def8084a7c6ca88b36ba772
# Push it to GitHub
git push --set-upstream origin backport/backport-778-to-0.5-nexus
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/opensearch-spark/backport-0.5-nexus

Then, create a pull request where the base branch is 0.5-nexus and the compare/head branch is backport/backport-778-to-0.5-nexus.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 14, 2024
Signed-off-by: Louis Chu <[email protected]>
(cherry picked from commit 0b106f1)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
noCharger pushed a commit that referenced this pull request Oct 14, 2024
(cherry picked from commit 0b106f1)

Signed-off-by: Louis Chu <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dr-lilienthal pushed a commit to eliatra/opensearch-spark that referenced this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants