PPL fieldsummary command
#766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- antlr syntax - ast expression builder - ast node builder - catalyst ast builder Signed-off-by: YANGDB <[email protected]>
- antlr syntax - ast expression builder - ast node builder - catalyst ast builder Signed-off-by: YANGDB <[email protected]>
fix scala style format Signed-off-by: YANGDB <[email protected]>
# Conflicts: # ppl-spark-integration/src/main/java/org/opensearch/sql/ast/AbstractNodeVisitor.java
YANG-DB
requested review from
dai-chen,
rupal-bq,
vmmusings,
penghuo,
seankao-az,
anirudha,
kaituo and
LantaoJin
as code owners
…ng table identifier only has 2 parts) Signed-off-by: YANGDB <[email protected]>
Signed-off-by: YANGDB <[email protected]>
Signed-off-by: YANGDB <[email protected]>
Signed-off-by: YANGDB <[email protected]>
Signed-off-by: YANGDB <[email protected]>
Signed-off-by: YANGDB <[email protected]>
# Conflicts: # ppl-spark-integration/src/main/java/org/opensearch/sql/ppl/parser/AstBuilder.java
Signed-off-by: YANGDB <[email protected]>
|
Would you mind change the PR status to DRAFT if you are going to refactor? |
|
@LantaoJin plz review |
LantaoJin
reviewed
Oct 22, 2024
| @ToString | ||
| @RequiredArgsConstructor | ||
| @EqualsAndHashCode(callSuper = false) | ||
| public class NamedExpression extends UnresolvedExpression { |
There was a problem hiding this comment.
Could you remove this definition or find an alternative, for example reusing Argument? Because
- NamedExpression should have a name
- NamedExpression generally should be an abstract class and the parent of Attribute or Alias. We should refactor many codes if we really need it.
- It's confused me with Spark NamedExpression, it is not worth to introduce a new expression for fieldsummary command IMO. At least, not
NamedExpression
| @@ -39,7 +42,8 @@ | |||
| */ | |||
| public interface DataTypeTransformer { | |||
| static <T> Seq<T> seq(T... elements) { | |||
| return seq(List.of(elements)); | |||
| return seq(Arrays.stream(elements).filter(Objects::nonNull) | |||
There was a problem hiding this comment.
Could you comment for this changes? What case did you see?
There was a problem hiding this comment.
yes its not relevant any more - thanks for pointing it out
| SUM(FunctionName.of("sum")), | ||
| COUNT(FunctionName.of("count")), | ||
| COUNT_DISTINCT(FunctionName.of("count_distinct")), |
There was a problem hiding this comment.
We do have a DISTINCT_COUNT. (did we miss it here?) And seems you are not use it as a built-in function name in following codes, instead, count_distinct is an alias name.
Signed-off-by: YANGDB <[email protected]>
LantaoJin
reviewed
Oct 23, 2024
Comment on lines
+91
to
+93
| FIELDSUMMARY: 'FIELDSUMMARY'; | ||
| INCLUDEFIELDS: 'INCLUDEFIELDS'; | ||
| NULLS: 'NULLS'; |
There was a problem hiding this comment.
We should add these keywords to keywordsCanBeId too.
|
|
||
| os> source = t | fieldsummary includefields= id, status_code, request_path nulls=true | ||
| +------------------+-------------+------------+------------+------------+------------+------------+------------+----------------| | ||
| | Fiels | COUNT | COUNT_DISTINCT | MIN | MAX | AVG | MEAN | STDDEV | NUlls | TYPEOF | |
|
|
||
| os> source = t | where status_code != 200 | fieldsummary includefields= status_code nulls=true | ||
| +------------------+-------------+------------+------------+------------+------------+------------+------------+----------------| | ||
| | Fiels | COUNT | COUNT_DISTINCT | MIN | MAX | AVG | MEAN | STDDEV | NUlls | TYPEOF | |
LantaoJin
approved these changes
Oct 24, 2024
kenrickyap
pushed a commit
to Bit-Quill/opensearch-spark
that referenced
this pull request
Dec 11, 2024
* add support for FieldSummary - antlr syntax - ast expression builder - ast node builder - catalyst ast builder Signed-off-by: YANGDB <[email protected]> * add support for FieldSummary - antlr syntax - ast expression builder - ast node builder - catalyst ast builder Signed-off-by: YANGDB <[email protected]> * update sample query fix scala style format Signed-off-by: YANGDB <[email protected]> * support spark prior to 3.5 with its extended table identifier (existing table identifier only has 2 parts) Signed-off-by: YANGDB <[email protected]> * update union queries based summary Signed-off-by: YANGDB <[email protected]> * update scala fmt style Signed-off-by: YANGDB <[email protected]> * update scala fmt style Signed-off-by: YANGDB <[email protected]> * update query with where clause predicate Signed-off-by: YANGDB <[email protected]> * update command and remove the topvalues Signed-off-by: YANGDB <[email protected]> * update command docs Signed-off-by: YANGDB <[email protected]> * update with comments feedback Signed-off-by: YANGDB <[email protected]> * update `FIELD SUMMARY` symbols to the keywordsCanBeId bag of words Signed-off-by: YANGDB <[email protected]> --------- Signed-off-by: YANGDB <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the
fieldsummaryPPL command.Issues Resolved
#662
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.