-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add planning document for PPL revisions #751
Conversation
Signed-off-by: YANGDB <[email protected]>
add reference to the plan Signed-off-by: YANGDB <[email protected]>
@LantaoJin please review and see if I haven't missed anything - |
- `since`: the version it was introduced | ||
|
||
--- | ||
## Version 0.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we going to follow semver? is minor versions will ensure the backward compatibility? Can we patch new commands to existing versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes thanks, I'll add this to the doc
- `since`: the version it was introduced | ||
|
||
--- | ||
## Version 0.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we change the version order to have recent versions first?
|
||
|
||
--- | ||
## Version 0.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is the current version, can you update to Version 0.5 (Current)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK the latest is 0.4.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anasalkouz I've updated 0.5.0 to be the current release (latest)
- `dedup` command with `allowedDuplication > 1` feature needs spark version >= 3.4 | ||
|
||
--- | ||
## Version 0.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming 0.5 is the current version. Why we need to add future versions? I think the purpose of this document to list commands against current and older versions, but not to document the roadmap or future work. is my understanding correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anasalkouz we do need to provide a plan for our future work to map into a version
- we need be transparent with our plans
- we need to allow the community to be aware of our goals and maybe try to influence
- we need our own team to be inform of what our plans are in terms of release and content
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've changed the doc to only reflect pre-release & released artifacts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anasalkouz I've removed future versions and only reflect former, existing and pre-release versions
- | ||
|
||
Each command / function would have the following properties: | ||
- `status`: the maturity of the feature (experimental, stable, deprecated) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the definitional of experimental?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
experimental is a feature that is just released and has no existing existence or reviewed in previous versions
I've added description for the different types
@@ -24,45 +24,45 @@ For additional examples see the next [documentation](PPL-Example-Commands.md). | |||
|
|||
- [`explain command `](PPL-Example-Commands.md/#explain) | |||
|
|||
- [`dedup command `](ppl-dedup-command.md) | |||
- [`dedup command `](commands/ppl-dedup-command.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we add version / since on each command doc?
### Limitations | ||
- `fields - list` shows incorrect results for spark version 3.3 - see [issue](https://github.com/opensearch-project/opensearch-spark/pull/732) | ||
- `eval` with comma separated expression needs spark version >= 3.4 | ||
- `dedup` command with `allowedDuplication > 1` feature needs spark version >= 3.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
L90: should be >=3.5.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename
also needs spark version >=3.5.1
| rare | experimental | 0.5 | | ||
| top | experimental | 0.5 | | ||
| join | experimental | 0.6 | | ||
| lookup | experimental | 0.6 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lookup
needs spark version >=3.5.1
- spark - status - introduced in Signed-off-by: YANGDB <[email protected]>
- spark - status - introduced in Signed-off-by: YANGDB <[email protected]>
closing this since we need to align on release process before using a dedicated issue |
Description
Add planning document for PPL revisions
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.