Fix FlintMetadata conversion issue in FlintOpenSearchClient #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `flint-core/src/main/scala/org/opensearch/flint/core/storage/FlintOpenSearchClient.java`, we encountered a conversion problem when transforming the index mapping to `FlintMetadata`. The root cause can be traced back to changes made in [this PR](https://github.com/opensearch-project/opensearch-spark/pull/70/files#diff-c3bdd10ec081d200e375aa601acff4c39b10bb4c34862634f56859f0054fedbf). Previously, `FlintMetadata` stored its content as a simple string. However, the recent changes have made its structure more complex, introducing fields like `version`, `name`, `kind`, `source`, `indexedColumns`, `options`, `properties`, `schema`, and `indexSettings`. Given that Flint index is specialized for storing covering index and materialized view metadata, it's not a typical data index. To address this, we've opted to use the OpenSearch rest client directly for the conversion. Testing done: 1. manual verification Signed-off-by: Kaituo Li <[email protected]>
kaituo
requested review from
dai-chen,
rupal-bq,
vmmusings,
penghuo and
anirudha
as code owners
penghuo
approved these changes
Oct 17, 2023
dai-chen
reviewed
Oct 17, 2023
spark-sql-application/src/main/scala/org/apache/spark/sql/FlintJob.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Kaituo Li <[email protected]>
ps48
approved these changes
Oct 17, 2023
|
@kaituo do you need help to merge this to main? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
flint-core/src/main/scala/org/opensearch/flint/core/storage/FlintOpenSearchClient.java, we encountered a conversion problem when transforming the index mapping toFlintMetadata. The root cause can be traced back to changes made in this PR.Previously,
FlintMetadatastored its content as a simple string. However, the recent changes have made its structure more complex, introducing fields likeversion,name,kind,source,indexedColumns,options,properties,schema, andindexSettings.Given that Flint index is specialized for storing covering index and materialized view metadata, it's not a typical data index. To address this, we've opted to use the OpenSearch rest client directly for the conversion.
Testing done:
Issues Resolved
#74
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.