Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement isBlank #749

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Implement isBlank #749

merged 1 commit into from
Oct 7, 2024

Conversation

salyh
Copy link
Contributor

@salyh salyh commented Oct 7, 2024

Description

Add isBlank as an "alias" to isEmpty

Issues Resolved

#513

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Hendrik Saly <[email protected]>
@salyh
Copy link
Contributor Author

salyh commented Oct 7, 2024

isBlank is implemented exactly like isEmpty because I dont see any differences between those two functions

@YANG-DB YANG-DB added 0.5 Lang:PPL Pipe Processing Language support backport 0.5-nexus labels Oct 7, 2024
@YANG-DB
Copy link
Member

YANG-DB commented Oct 7, 2024

@salyh
please add the needed documentation in the following locations:

@salyh
Copy link
Contributor Author

salyh commented Oct 7, 2024

@salyh please add the needed documentation in the following locations:

* [ppl commands list](https://github.com/opensearch-project/opensearch-spark/tree/main/docs/ppl-lang)

* [ppl functions list](https://github.com/opensearch-project/opensearch-spark/tree/main/docs/ppl-lang/functions)

* [ppl examples doc](https://github.com/opensearch-project/opensearch-spark/blob/main/docs/ppl-lang/PPL-Example-Commands.md)

already done: https://github.com/opensearch-project/opensearch-spark/pull/749/files

Let me know if you miss anything specific

@YANG-DB YANG-DB merged commit e3a19dd into opensearch-project:main Oct 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.6 Lang:PPL Pipe Processing Language support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants