Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Fields Minus Command #698

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

LantaoJin
Copy link
Member

Description

Support fields - <field list> syntax

Check https://opensearch.org/docs/latest/search-plugins/sql/ppl/functions/#syntax-2

Issues Resolved

Resolves #696

Check List

  • Updated documentation (ppl-spark-integration/README.md)
  • Implemented unit tests
  • Implemented tests for combination with other commands
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Lantao Jin <[email protected]>
@YANG-DB YANG-DB merged commit 919ba5c into opensearch-project:main Sep 25, 2024
4 checks passed
@YANG-DB YANG-DB added 0.5 Lang:PPL Pipe Processing Language support backport 0.5-nexus labels Oct 2, 2024
@opensearch-trigger-bot
Copy link

The backport to 0.5-nexus failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/opensearch-spark/backport-0.5-nexus 0.5-nexus
# Navigate to the new working tree
pushd ../.worktrees/opensearch-spark/backport-0.5-nexus
# Create a new branch
git switch --create backport/backport-698-to-0.5-nexus
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 919ba5ce4c2c7179c1f80508a4672ee685dbced3
# Push it to GitHub
git push --set-upstream origin backport/backport-698-to-0.5-nexus
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/opensearch-spark/backport-0.5-nexus

Then, create a pull request where the base branch is 0.5-nexus and the compare/head branch is backport/backport-698-to-0.5-nexus.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 2, 2024
* Support Fields Minus Command

Signed-off-by: Lantao Jin <[email protected]>

* add limitation

Signed-off-by: Lantao Jin <[email protected]>

---------

Signed-off-by: Lantao Jin <[email protected]>
(cherry picked from commit 919ba5c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
noCharger pushed a commit that referenced this pull request Oct 2, 2024
* Support Fields Minus Command



* add limitation



---------


(cherry picked from commit 919ba5c)

Signed-off-by: Lantao Jin <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
LantaoJin added a commit to LantaoJin/opensearch-spark that referenced this pull request Oct 2, 2024
* Support Fields Minus Command

Signed-off-by: Lantao Jin <[email protected]>

* add limitation

Signed-off-by: Lantao Jin <[email protected]>

---------

Signed-off-by: Lantao Jin <[email protected]>
(cherry picked from commit 919ba5c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Support fields - <field list>
2 participants