Add explain command #687
Merged
Add explain command #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kt-eliatra
requested review from
dai-chen,
rupal-bq,
vamsimanohar,
penghuo,
seankao-az,
anirudha,
kaituo and
YANG-DB
as code owners
|
Please add command usage examples in the main readme markdown |
done |
YANG-DB
reviewed
Sep 25, 2024
| @@ -123,7 +125,8 @@ public LogicalPlan visitQuery(Query node, CatalystPlanContext context) { | |||
|
|
|||
| @Override | |||
| public LogicalPlan visitExplain(Explain node, CatalystPlanContext context) { | |||
| return node.getStatement().accept(this, context); | |||
| node.getStatement().accept(this, context); | |||
| return context.apply(p -> new ExplainCommand(p, ExplainMode.fromString("simple"))); | |||
There was a problem hiding this comment.
what other explain types can we engage ?
There was a problem hiding this comment.
formatted
cost
codegen
extended
simple
YANG-DB
reviewed
Sep 25, 2024
There was a problem hiding this comment.
Can you please review the explain options ?
and also add an explain test to validate the expected result ? - it would be nice to add these parameters for the user to request...
the explain command supports now |
Signed-off-by: Kacper Trochimiak <[email protected]>
Signed-off-by: Kacper Trochimiak <[email protected]>
…PLSyntaxParser Signed-off-by: Kacper Trochimiak <[email protected]>
Signed-off-by: Kacper Trochimiak <[email protected]>
Signed-off-by: Kacper Trochimiak <[email protected]>
Signed-off-by: Kacper Trochimiak <[email protected]>
Signed-off-by: Kacper Trochimiak <[email protected]>
Signed-off-by: Kacper Trochimiak <[email protected]>
Signed-off-by: Kacper Trochimiak <[email protected]>
Signed-off-by: Kacper Trochimiak <[email protected]>
YANG-DB
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add explain command
Issues Resolved
#556
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.