Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate PPL LOOKUP Command #686

Merged
merged 5 commits into from
Sep 25, 2024
Merged

Translate PPL LOOKUP Command #686

merged 5 commits into from
Sep 25, 2024

Conversation

LantaoJin
Copy link
Member

@LantaoJin LantaoJin commented Sep 20, 2024 •
edited
Loading

Description

Syntax

| LOOKUP <lookupIndex> (<lookupMappingField> [AS <sourceMappingField>])...
    [(REPLACE | APPEND) (<inputField> [AS <outputField>])...]

Issues Resolved

Resolves #620 and parent issue opensearch-project/sql#2651

Check List

  • Updated documentation (ppl-spark-integration/README.md)
  • Implemented unit tests
  • Implemented tests for combination with other commands
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@LantaoJin LantaoJin marked this pull request as ready for review September 23, 2024 12:45
@LantaoJin
fix scalafmt
81960c3 
Signed-off-by: Lantao Jin <[email protected]>
YANG-DB
YANG-DB reviewed Sep 23, 2024
View reviewed changes
Copy link
Member

@YANG-DB YANG-DB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going over the code - looking good so far...

Please add a dedicated lookup markdown with details in a similar way to the join markdown.
In addition please add examples to the main readme doc
Thanks 🙏

@LantaoJin
add docs
bdf3778 
Signed-off-by: Lantao Jin <[email protected]>
@LantaoJin LantaoJin mentioned this pull request Sep 24, 2024
Open
@LantaoJin LantaoJin requested a review from YANG-DB September 24, 2024 14:20
@YANG-DB YANG-DB added the Lang:PPL Pipe Processing Language support label Sep 25, 2024
@YANG-DB YANG-DB merged commit 0b248ec into opensearch-project:main Sep 25, 2024
5 checks passed
@YANG-DB YANG-DB added the 0.6 label Sep 25, 2024
@LantaoJin LantaoJin mentioned this pull request Oct 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YANG-DB YANG-DB YANG-DB approved these changes

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@rupal-bq rupal-bq Awaiting requested review from rupal-bq

@vmmusings vmmusings Awaiting requested review from vmmusings

@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

@kaituo kaituo Awaiting requested review from kaituo kaituo is a code owner

Assignees
No one assigned
Labels
0.6 Lang:PPL Pipe Processing Language support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Support Lookup Command in PPL.
2 participants
@LantaoJin @YANG-DB