Optional support for getAllIndexMetadata by index pattern #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seankao-az
requested review from
dai-chen,
rupal-bq,
vamsimanohar,
penghuo,
anirudha,
kaituo and
YANG-DB
as code owners
dai-chen
approved these changes
Sep 20, 2024
Signed-off-by: Sean Kao <[email protected]>
seankao-az
force-pushed
the
get-all-index-metadata-remove-pattern
branch
from
1bc6bc1 to
0e7fc47
Compare
|
removed some unused import |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 23, 2024
Signed-off-by: Sean Kao <[email protected]> (cherry picked from commit 05e7f23) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
seankao-az
pushed a commit
that referenced
this pull request
Sep 23, 2024
(cherry picked from commit 05e7f23) Signed-off-by: Sean Kao <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
noCharger
reviewed
Sep 24, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 24, 2024
Signed-off-by: Sean Kao <[email protected]> (cherry picked from commit 05e7f23) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
noCharger
pushed a commit
that referenced
this pull request
Sep 24, 2024
(cherry picked from commit 05e7f23) Signed-off-by: Sean Kao <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FlintIndexMetadataServiceused to use index pattern (using wildcard character*) to fetch index metadata for indexes matching the pattern. This change makes supporting getting by pattern optional. Instead, the service could fetch index metadata for full index names.This does not change the
FlintSpark.describeIndexesapi, which still takes an index pattern as argument.Alternative Considered
Alternative is to not use index pattern in
FlintIndexMetadataService.getAllIndexMetadataat all, and instead always take full index names. However, this adds number of requests overhead for services that do allow for pattern matching, e.g. OpenSearch implementationFlintOpenSearchIndexMetadataService. Instead of making 1 request, a pattern that matches to N indexes would require N requests to fetch their metadata, if getting by pattern is removed completely.Issues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.