Add support for serializing TimestampNTZType #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chase Engelbrecht <[email protected]>
Signed-off-by: Chase Engelbrecht <[email protected]>
engechas
requested review from
dai-chen,
rupal-bq,
vmmusings,
penghuo,
seankao-az,
anirudha,
kaituo and
YANG-DB
as code owners
noCharger
approved these changes
Sep 17, 2024
dai-chen
approved these changes
Sep 19, 2024
There doesn't seem to be. Both types are ultimately dates in OpenSearch and use the same format, one just has a TZ attached whereas the other doesn't |
|
@noCharger Not sure whether we want to backport this. Please label accordingly. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 19, 2024
* Add support for TIMESTAMP_NTZ in FlintDataType Signed-off-by: Chase Engelbrecht <[email protected]> * Add unit test Signed-off-by: Chase Engelbrecht <[email protected]> --------- Signed-off-by: Chase Engelbrecht <[email protected]> (cherry picked from commit 7ff1512) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 19, 2024
* Add support for TIMESTAMP_NTZ in FlintDataType Signed-off-by: Chase Engelbrecht <[email protected]> * Add unit test Signed-off-by: Chase Engelbrecht <[email protected]> --------- Signed-off-by: Chase Engelbrecht <[email protected]> (cherry picked from commit 7ff1512) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
noCharger
pushed a commit
that referenced
this pull request
Sep 20, 2024
* Add support for TIMESTAMP_NTZ in FlintDataType * Add unit test --------- (cherry picked from commit 7ff1512) Signed-off-by: Chase Engelbrecht <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
noCharger
pushed a commit
that referenced
this pull request
Sep 20, 2024
* Add support for TIMESTAMP_NTZ in FlintDataType * Add unit test --------- (cherry picked from commit 7ff1512) Signed-off-by: Chase Engelbrecht <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for serializing TimestampNTZType by considering it the same case as a TimestampType
Issues Resolved
N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.