Add langType to FlintStatement model #664
Conversation
Signed-off-by: Louis Chu <[email protected]>
noCharger
requested review from
dai-chen,
rupal-bq,
vamsimanohar,
penghuo,
seankao-az,
anirudha,
kaituo and
YANG-DB
as code owners
| query, | ||
| "", | ||
| queryId, | ||
| LangType.SQL, |
There was a problem hiding this comment.
Not a big concern but I feel like hard coded SQL isn't ideal. In principle our batch FlintJob could run even if provided with a PPL query.
However, if the language type isn't passed from async-query-core to the spark job by setting the spark conf, then really there's no way to get this lang type dynamically.
I know that our async-query-core use case always use FlintJob for Flint extension SQL queries only, so this could be fine
There was a problem hiding this comment.
Exactly, FlintJob is only used for SQL use case hense langType not passed to parameter https://github.com/opensearch-project/sql/blob/25064688db2d08e61579aaf7d21ff440c67605a4/async-query-core/src/main/java/org/opensearch/sql/spark/data/constants/SparkConstants.java#L88-L89. With warmpool the FlintStatement should come from async-query-core statement model.
Signed-off-by: Louis Chu <[email protected]> (cherry picked from commit 7a4c206) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Louis Chu <[email protected]> (cherry picked from commit 7a4c206) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 7a4c206) Signed-off-by: Louis Chu <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 7a4c206) Signed-off-by: Louis Chu <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Add langType to FlintStatement model
Issues Resolved
N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.